Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Encrypt oauth client id/secret and user tokens #112

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Encrypt oauth client id/secret and user tokens #112

merged 1 commit into from
Oct 18, 2024

Conversation

julien-nc
Copy link
Member

  • Encrypt some sensitive admin setting values (client id/secret)
  • Encrypt tokens and refresh tokens of user accounts
  • Migrate existing stored admin and user values

@julien-nc julien-nc added enhancement New feature or request 3. to review labels Oct 18, 2024
@julien-nc julien-nc requested review from kyteinsky, marcelklehr and provokateurin and removed request for marcelklehr October 18, 2024 08:51
kyteinsky
kyteinsky reviewed Oct 18, 2024
View reviewed changes
lib/Service/ConfigService.php Outdated
) {
}

public function getEncryptedAppValue(string $key): string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getClearAppValue would suit the naming convention

@julien-nc
encrypt oauth client id/secret and user tokens
848dea7 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the enh/noid/encrypt-secrets branch from fe76865 to 848dea7 Compare October 18, 2024 13:42
@julien-nc julien-nc merged commit c144a60 into main Oct 18, 2024
33 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kyteinsky kyteinsky kyteinsky approved these changes

@marcelklehr marcelklehr Awaiting requested review from marcelklehr marcelklehr is a code owner

@provokateurin provokateurin Awaiting requested review from provokateurin

Assignees
No one assigned
Labels
3. to review enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-nc @kyteinsky