Fix flickering toolbar #1311
Merged
Fix flickering toolbar #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christine Coenen <code.coenen@gmail.com>
Signed-off-by: Christine Coenen <code.coenen@gmail.com>
Signed-off-by: Christine Coenen <code.coenen@gmail.com>
|
This implementation now seems to work great. I tested it on api level 34 and 26 each with SSO and manual login and both light and dark themes. I think, the account button has a position a bit too prominent in the toolbar. But for now, it does work as before. |
cemrich
commented
Nov 1, 2023
News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderListActivity.java
Show resolved
Hide resolved
cemrich
commented
Nov 1, 2023
News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderListActivity.java
Show resolved
Hide resolved
cemrich
commented
Nov 1, 2023
News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/model/OcsUser.java
Show resolved
Hide resolved
cemrich
commented
Nov 1, 2023
cemrich
commented
Nov 1, 2023
cemrich
commented
Nov 1, 2023
|
@cemrich Thank you a lot for looking into this. I tested it against the Light, Dark and Dark with OLED Theme and it works great in all cases! |
Closed
|
Thanks @cemrich your work is appreciated! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a proof of concept - but I think this fixes the flickering. I tested on API level 26 and 34.
The implementation of the Toolbar is as documented in the Material Design Components docs.
The account button is now a menu item and looks and behaves exactly as all other menu icons without further configuration. It is visible between the search icon and the overflow menu icon (if room).
Fixes #1291