Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Hide deprecated projects in sidebar by default #2544

Closed
wants to merge 11 commits into from
Closed

Hide deprecated projects in sidebar by default #2544

wants to merge 11 commits into from

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Aug 18, 2022

Deprecate projects which is superseded by Related resources nextcloud/server#28320

Pytal added 2 commits August 18, 2022 02:07
@Pytal
Bump max supported Nextcloud version
6f0f695 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Hide deprecated projects in sidebar by default
895d754 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added this to the 3.8.0 milestone Aug 18, 2022
@Pytal Pytal requested review from splitt3r, v1r0x and dartcafe August 18, 2022 02:32
@Pytal Pytal self-assigned this Aug 18, 2022
@Pytal Pytal mentioned this pull request Aug 20, 2022
Open
5 tasks
@dartcafe dartcafe modified the milestones: 3.8.0, 4.0 Aug 20, 2022
@dartcafe

This comment was marked as outdated.

# to view
dartcafe
dartcafe requested changes Aug 20, 2022
View reviewed changes
Copy link
Collaborator

@dartcafe dartcafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to block merging to the master branch too early.

@dartcafe dartcafe self-requested a review August 27, 2022 10:46
dartcafe
dartcafe requested changes Aug 27, 2022
View reviewed changes
Copy link
Collaborator

@dartcafe dartcafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nextcloud/initial-state is missing as module

@dartcafe
Copy link
Collaborator

@Pytal I added @nextcloud/intial-state

But loadState('core', 'projects_enabled', false) always returns false, regardless what I define in the config file ('projects.enabled' => true,). NC25-beta3

dartcafe and others added 8 commits August 30, 2022 22:30
@dartcafe
add missing @nextcloud/initial-state
f2a5d43 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
Revert "add missing @nextcloud/initial-state"
f4c29ff 
This reverts commit f2a5d43.

Signed-off-by: dartcafe <github@dartcafe.de>
@Pytal @dartcafe
Hide deprecated projects in sidebar by default
1e41b10 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@dartcafe
add missing @nextcloud/initial-state
89f6352 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
Revert "add missing @nextcloud/initial-state"
7f58c89 
This reverts commit f2a5d43.

Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
Merge branch 'enh/hide-projects' of https://github.com/nextcloud/polls …
545d8e3 
…into enh/hide-projects

Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
npm install
9bdbaca 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
install @nextcloud/initial-state again
1244f0b 
Signed-off-by: dartcafe <github@dartcafe.de>
@Pytal
Copy link
Member Author

Pytal commented Sep 1, 2022

From the commits this looks like it needs a rebase first @dartcafe

@dartcafe
Copy link
Collaborator

dartcafe commented Sep 1, 2022

From the commits this looks like it needs a rebase first @dartcafe

I did.

@dartcafe dartcafe mentioned this pull request Sep 2, 2022
Merged
@dartcafe
Merge branch 'master' into enh/hide-projects
0864777 
Signed-off-by: René Gieling <github@dartcafe.de>
@dartcafe
Copy link
Collaborator

dartcafe commented Sep 2, 2022

@Pytal I think, I messed this pr up. Maybe you could restart in a fresh branch from ne current master branch?

But I still have the problem, that I cannot activate projects to test it.

@Pytal
Copy link
Member Author

Pytal commented Sep 9, 2022

@Pytal I think, I messed this pr up. Maybe you could restart in a fresh branch from ne current master branch?

But I still have the problem, that I cannot activate projects to test it.

No worries, feel free to apply this commit 895d754 in another PR and testing it on https://github.com/nextcloud/server master branch should work

@dartcafe dartcafe mentioned this pull request Sep 10, 2022
Merged
@dartcafe
Copy link
Collaborator

closed in favour of #2585

@dartcafe dartcafe closed this Sep 10, 2022
@dartcafe dartcafe reopened this Sep 17, 2022
@dartcafe dartcafe closed this Sep 17, 2022
@dartcafe dartcafe deleted the enh/hide-projects branch October 25, 2022 19:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dartcafe dartcafe dartcafe requested changes

@splitt3r splitt3r Awaiting requested review from splitt3r

@v1r0x v1r0x Awaiting requested review from v1r0x

Assignees

@Pytal Pytal

Labels
3. to review
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Pytal @dartcafe