-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add $extraParams for setUserStatus OCP to handle extra user status attributes #32321
Conversation
Note: This will help to work with mapping statuses to calendar events in the future (we only need to check the start date of the event, not it's end). |
320ac1c
to
22b4a6e
Compare
…tributes Signed-off-by: Thomas Citharel <tcit@tcit.fr>
22b4a6e
to
f65196c
Compare
I'm not really satisfied with that so we might as well make |
I do not have a strong opinion here, I do not know this part of the code enough. @CarlSchwan Any opinion? Note that current code makes psalm angry as array structure accepted by implementer is more strict than interface. |
Many conflicts 🙈 |
@@ -53,9 +53,10 @@ public function getUserStatuses(array $userIds): array; | |||
* @param string $messageId The id of the predefined message. | |||
* @param string $status The status to assign | |||
* @param bool $createBackup If true, this will store the old status so that it is possible to revert it later (e.g. after a call). | |||
* @param array $extraParams Pass extra parameters to the user status implementation provider. Refer to the provider implementation to determine which keys are supported. Added in 25.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Info needs to be added in a new @since
And it must be 29 or 30 now :P
Closing this pull request due to lack of recent activity and updates. We appreciate your contribution and encourage you to reopen or provide further updates if necessary. |
Allows to pass extra params to the UserStatus provider through OCP, here used to: