-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add an OCP API for console commands #32780
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
$this->setDescription($this->command->getDescription()); | ||
} | ||
|
||
protected function execute(InputInterface $input, OutputInterface $output) { |
Check failure
Code scanning / Psalm
InvalidReturnType
No return statements were found for method OC\Command\SymfonyCommandAdapter::execute but return type 'int' was expected
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
return 'List all calendars of a user'; | ||
} | ||
|
||
public function configure(IConfiguration $configuration): void { |
Check failure
Code scanning / Psalm
ParamNameMismatch
Argument 1 of OCA\DAV\Command\ListCalendars::configure has wrong name $configuration, expecting $config as defined by OCP\Command\Command::configure
Realistically I don't have time to finish this, even if I really wish we had such an API soon. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very similar to #32332 but without leaking any Symfony types in our API.
The goal is to get as close to Symfony as necessary but without tight coupling.
Todo