Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

use LazyUser in SetupManager #33582

Closed
wants to merge 5 commits into from
Closed

use LazyUser in SetupManager #33582

wants to merge 5 commits into from

Conversation

icewind1991
Copy link
Member

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991 icewind1991 added this to the Nextcloud 25 milestone Aug 17, 2022
@icewind1991 icewind1991 requested review from a team, blizzz, juliusknorr and CarlSchwan and removed request for a team August 17, 2022 12:41
PVince81
PVince81 approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 otherwise

@skjnldsv skjnldsv mentioned this pull request Aug 18, 2022
Merged
@juliusknorr
Copy link
Member

juliusknorr commented Aug 18, 2022 •
edited
Loading

Tests are failing quite a lot:

OC\User\LazyUser::getUser(): Return value must be of type OCP\IUser, null returned

/home/runner/work/server/server/lib/private/User/LazyUser.php:46
/home/runner/work/server/server/lib/private/User/LazyUser.php:78
/home/runner/work/server/server/lib/private/Files/Storage/Home.php:52
/home/runner/work/server/server/lib/private/Files/Mount/MountPoint.php:167
/home/runner/work/server/server/lib/private/Files/Mount/MountPoint.php:192
/home/runner/work/server/server/lib/private/Files/Filesystem.php:321
/home/runner/work/server/server/lib/private/Files/View.php:227
/home/runner/work/server/server/lib/private/Files/View.php:1859
/home/runner/work/server/server/apps/dav/lib/Connector/Sabre/Directory.php:437
/home/runner/work/server/server/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:425
/home/runner/work/server/server/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:374

@icewind1991 icewind1991 force-pushed the setupmanager-lazy-user branch 3 times, most recently from 4ad6695 to 6358458 Compare August 19, 2022 12:59
@blizzz
Copy link
Member

blizzz commented Aug 19, 2022

☝

This was referenced Aug 24, 2022
Merged
Merged
@icewind1991
use LazyUser in SetupManager
45ad8c5 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
clear the display name cache between tests
cae1175 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
remove cached display name on user delete
ee1a5ec 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
adjust user_ldap tests
1214c4f 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the setupmanager-lazy-user branch from 6358458 to 466edc2 Compare September 1, 2022 16:19
@icewind1991 icewind1991 mentioned this pull request Sep 1, 2022
Closed
@icewind1991
also hard error if the home storage can't be created
0ae7653 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the setupmanager-lazy-user branch from 466edc2 to 0ae7653 Compare September 1, 2022 17:44
This was referenced Sep 6, 2022
Merged
Merged
@blizzz blizzz added this to the Nextcloud 27 milestone Mar 9, 2023
@szaimen
Copy link
Contributor

szaimen commented Apr 17, 2023

@icewind1991 please fix the conflicts and tests

This was referenced May 3, 2023
Merged
Closed
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 9, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
This was referenced Jul 30, 2024
Merged
Merged
This was referenced Aug 5, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@skjnldsv skjnldsv closed this Aug 14, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@skjnldsv skjnldsv deleted the setupmanager-lazy-user branch August 30, 2024 07:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees
No one assigned
Labels
2. developing Work in progress performance 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@icewind1991 @juliusknorr @blizzz @szaimen @PVince81 @skjnldsv