Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor core/Command/Background #39184

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

shdehnavi
Copy link
Contributor

Summary

The required adjustments have been made to the classes in /core/Command/Background namespace.

The improvements:

  • Adding return types
  • Adding throws types
  • Updating doc blocks

Checklist

@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 6, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Jul 6, 2023
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash your commits into one please

👍 thanks

@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
shdehnavi and others added 3 commits February 23, 2024 16:57
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@skjnldsv skjnldsv force-pushed the refactor_core_command_background branch from 607f75e to 7062314 Compare February 23, 2024 15:57
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 23, 2024
@skjnldsv skjnldsv enabled auto-merge February 23, 2024 15:58
@skjnldsv skjnldsv disabled auto-merge February 23, 2024 20:31
@skjnldsv skjnldsv merged commit 7cf3172 into nextcloud:master Feb 23, 2024
149 of 158 checks passed
@shdehnavi shdehnavi deleted the refactor_core_command_background branch February 26, 2024 10:50
@blizzz blizzz mentioned this pull request Mar 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants