Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

enh(settings): Add SetupCheck to ensure webserver correctly serves .mjs files #42436

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 21, 2023

Summary

Even if it was noted in the upgrade guides for Nextcloud 27 some instances are not correctly configured to server .mjs files as JavaScript. This breaks apps like logreader.
So this adds a setup check for validating the server is correctly configured.

Checklist

@susnux susnux added the 3. to review Waiting for reviews label Dec 21, 2023
@susnux susnux added this to the Nextcloud 29 milestone Dec 21, 2023
susnux and others added 2 commits January 10, 2024 11:58
…mjs` files

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the enh/add-mjs-setup-check branch from 51273e2 to c5fbd96 Compare January 10, 2024 10:58
@susnux
Copy link
Contributor Author

susnux commented Jan 15, 2024

/skjnldsv-backport to stable28

@susnux
Copy link
Contributor Author

susnux commented Jan 15, 2024

cypress unrelated

@susnux susnux merged commit 265e906 into master Jan 15, 2024
47 of 49 checks passed
@susnux susnux deleted the enh/add-mjs-setup-check branch January 15, 2024 17:21
@blizzz blizzz mentioned this pull request Mar 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants