-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
enh(settings): Add SetupCheck to ensure webserver correctly serves .mjs
files
#42436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
801b8d3
to
39c0345
Compare
come-nc
reviewed
Jan 4, 2024
come-nc
approved these changes
Jan 9, 2024
…mjs` files Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
51273e2
to
c5fbd96
Compare
/skjnldsv-backport to stable28 |
artonge
reviewed
Jan 15, 2024
artonge
approved these changes
Jan 15, 2024
cypress unrelated |
9 tasks
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Even if it was noted in the upgrade guides for Nextcloud 27 some instances are not correctly configured to server
.mjs
files as JavaScript. This breaks apps like logreader.So this adds a setup check for validating the server is correctly configured.
Checklist