Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Apply group limit on remove from group #47180

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Apply group limit on remove from group #47180

merged 6 commits into from
Aug 13, 2024
+167 −8

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Aug 12, 2024 •
edited
Loading

Summary

When removing a user from a group, remove shares which would not be creatable anymore according to group limit on sharing.

Checklist

@artonge @come-nc
fix(files_sharing): Delete user shares if needed when user is removed…
5559beb 
… from a group

Signed-off-by: Louis Chemineau <louis@chmn.me>
@come-nc come-nc added the 2. developing Work in progress label Aug 12, 2024
@come-nc come-nc added this to the Nextcloud 30 milestone Aug 12, 2024
@come-nc come-nc self-assigned this Aug 12, 2024
@come-nc come-nc force-pushed the fix/apply-group-limit-on-remove-from-group branch from c57bb08 to f217c6e Compare August 12, 2024 12:44
@come-nc
Copy link
Contributor Author

come-nc commented Aug 12, 2024

/backport to stable29

@come-nc
Copy link
Contributor Author

come-nc commented Aug 12, 2024

/backport to stable28

artonge and others added 4 commits August 12, 2024 15:20
@artonge @come-nc
chore(tests): Test limiting sharing to same group
b6e28bb 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@come-nc
fix: Remove shares only if there are no more common groups between users
e23325f 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix(tests): Adapt tests to change of DefaultShareProvider constructor
1cfc25d 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
chore(tests): Fix SPDX license header on new cypress test
244491a 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/apply-group-limit-on-remove-from-group branch from 2744f31 to 244491a Compare August 12, 2024 13:22
@come-nc
chore(tests): Fix import in cypress test limit_to_same_group.cy.ts
e7854a9 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 13, 2024
@come-nc come-nc requested review from a team, ArtificialOwl, yemkareems and provokateurin and removed request for a team August 13, 2024 08:08
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@come-nc come-nc merged commit 142b6e3 into master Aug 13, 2024
169 checks passed
@come-nc come-nc deleted the fix/apply-group-limit-on-remove-from-group branch August 13, 2024 10:20
This was referenced Aug 13, 2024
Closed
Merged
@hamza221
Copy link
Contributor

/backport to stable26

@backportbot backportbot bot mentioned this pull request Aug 15, 2024
Closed
2 tasks
This was referenced Aug 19, 2024
Merged
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@yemkareems yemkareems yemkareems approved these changes

@bigcat88 bigcat88 bigcat88 approved these changes

@miaulalala miaulalala miaulalala approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin was automatically assigned from nextcloud/server-backend

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
6 participants
@come-nc @hamza221 @miaulalala @bigcat88 @yemkareems @artonge