fix: Use sha256 to hash arguments of background jobs #47769
Merged
+89
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
enhancement
3. to review
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
artonge
force-pushed
the
artonge/fix/use_sha256_for_arguments_hash_forbg_jobs
branch
from
b09b8d1
to
0460f00
Compare
sorbaugh
approved these changes
Sep 5, 2024
provokateurin
approved these changes
Sep 5, 2024
artonge
force-pushed
the
artonge/fix/use_sha256_for_arguments_hash_forbg_jobs
branch
from
0460f00
to
dc2d4d6
Compare
This is to prevent collision as we are sometime hashing user input, yet using that hash to target the background job in the database. Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/use_sha256_for_arguments_hash_forbg_jobs
branch
from
dc2d4d6
to
dbf56b6
Compare
AndyScherzinger
approved these changes
Sep 5, 2024
sorbaugh
deleted the
artonge/fix/use_sha256_for_arguments_hash_forbg_jobs
branch
This was referenced Sep 5, 2024
kesselb
added a commit
that referenced
this pull request
Sep 12, 2024
Follow-up for #47769 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
5 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are using this hash as ID, it makes it more reliable than the current md5 hash we are using.