fix(SharingEntryLink): Show default password before create if any #49115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
fix/48860/stop-silent-expiry-date-addition-on-link-shares
branch
3 times, most recently
from
28c9676 to
808f07a
Compare
This was
linked to
issues
Nov 7, 2024
|
Looks good! Related: #46837 (not sure if this fixes that too) |
8 tasks
susnux
approved these changes
Nov 7, 2024
Prevent silent addition of expiration date to shares. Prevent silent addition for password to shares. Both now have a `shareRequiresReview` check Resolves : #48860 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/48860/stop-silent-expiry-date-addition-on-link-shares
branch
from
808f07a to
6d3f5d3
Compare
Not exactly might require a separate PR. Took it. |
|
/compile |
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
skjnldsv
approved these changes
Nov 8, 2024
nfebe
deleted the
fix/48860/stop-silent-expiry-date-addition-on-link-shares
branch
2 tasks
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/49115/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 6d3f5d39 1f17b2f8
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49115/stable29Error: Failed to push branch backport/49115/stable29: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
2 tasks
|
8 tasks
|
the backport to stable29 has not made the cut, correct? Can you retry backporting please? |
Merged
4 tasks
8 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent silent addition of expiration date to shares.
Resolves : #48860
Screenshots