enh: Fix display default expire date, add tests & tiny refactors #50655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
fix/share-sidebar-bugs
branch
from
97c913b to
e0450ea
Compare
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
nfebe
requested review from
AndyScherzinger,
susnux,
artonge,
Pytal and
sorbaugh
nfebe
force-pushed
the
fix/share-sidebar-bugs
branch
from
e4f5688 to
02c58f8
Compare
|
/compile |
susnux
reviewed
Feb 5, 2025
skjnldsv
reviewed
Feb 5, 2025
nfebe
force-pushed
the
fix/share-sidebar-bugs
branch
3 times, most recently
from
dda04e8 to
c83bef6
Compare
skjnldsv
approved these changes
Feb 5, 2025
nfebe
force-pushed
the
fix/share-sidebar-bugs
branch
from
c83bef6 to
883819d
Compare
|
/compile |
susnux
approved these changes
Feb 5, 2025
| @@ -751,7 +751,7 @@ public function createShare( | |||
| $share->setSharedWith($shareWith); | |||
| $share->setPermissions($permissions); | |||
| } elseif ($shareType === IShare::TYPE_CIRCLE) { | |||
| if (!\OC::$server->getAppManager()->isEnabledForUser('circles') || !class_exists('\OCA\Circles\ShareByCircleProvider')) { | |||
| if (!\OC::$server->get(IAppManager::class)->isEnabledForUser('circles') || !class_exists('\OCA\Circles\ShareByCircleProvider')) { | |||
There was a problem hiding this comment.
Suggested change
| if (!\OC::$server->get(IAppManager::class)->isEnabledForUser('circles') || !class_exists('\OCA\Circles\ShareByCircleProvider')) { | |
| if (!\OCP\Server::get(IAppManager::class)->isEnabledForUser('circles') || !class_exists('\OCA\Circles\ShareByCircleProvider')) { |
nfebe
force-pushed
the
fix/share-sidebar-bugs
branch
from
d5594b0 to
ea9c3ab
Compare
marcoambrosini
approved these changes
Feb 6, 2025
artonge
approved these changes
Feb 6, 2025
nfebe
force-pushed
the
fix/share-sidebar-bugs
branch
from
ea9c3ab to
d9b250a
Compare
nfebe
force-pushed
the
fix/share-sidebar-bugs
branch
from
d9b250a to
fb207ea
Compare
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Since `ShareEntryLink` component is used to both create and display/list the share links, we should only set default expiration date on `share.expireDate` when we know is a new share. Otherwise, we overidding data from the backend. Signed-off-by: nfebe <fenn25.fn@gmail.com>
…reate share Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
…nput Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nfebe
force-pushed
the
fix/share-sidebar-bugs
branch
from
fb207ea to
a544252
Compare
This was referenced Feb 6, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : #50495
Screencasts
Show default expiration date before create share
show-default-date.mp4
Quick share select updated without refresh
quick-share.mp4
Checklist