fix(TimedJob): Add time leeway in start condition #50868
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since cron jobs may not always run at the very same second, e.g. at 10:45:16 and at 10:50:14, some jobs (depending on the interval) that should actually run wouldn't be started when exactly comparing the interval with the time of the last run. Therefore, allow a time leeway of a few seconds. Signed-off-by: Matthias Meusburger <matthias.meusburger@gmx.at>
9 tasks
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
|
Still not optimal. If a job that is executed before the critical one took a long time during the last cron run (e.g. UpdateAvailableNotifications), the critical one could still be skipped on the next run. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since cron jobs may not always run at the very same second (observed in web hosting environment), e.g. at 10:45:16 and at 10:50:14, some jobs (depending on the interval) that should actually run wouldn't be started when exactly comparing the interval with the time of the last run. Therefore, a time leeway of a few seconds should be allowed.
Checklist
Screenshots before/after for front-end changes