Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(setupcheck): check logging level for validity #50927

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 20, 2025

Summary

Check for log level validity to detect issues before they happen.

Checklist

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be merged with nextcloud/server/apps/settings/lib/SetupChecks/DebugMode.php ?

@susnux
Copy link
Contributor Author

susnux commented Feb 21, 2025

Could be merged with nextcloud/server/apps/settings/lib/SetupChecks/DebugMode.php ?

Could yes, but it does also check the logging level format which is not about debug mode, so probably two distinct checks

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/setup-check-logging branch from bfbb847 to f91db18 Compare February 22, 2025 13:08
@susnux susnux merged commit 39417b1 into master Feb 23, 2025
190 checks passed
@susnux susnux deleted the feat/setup-check-logging branch February 23, 2025 13:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup check for loglevel: warn when set to debug level (0) or when set to an invalid value
5 participants