Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make NC30 compatible #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make NC30 compatible #261

wants to merge 1 commit into from

Conversation

ervee
Copy link

@ervee ervee commented Oct 28, 2024

Make the app compatible with Nextcloud 30

Fixes #260

Changes proposed in this pull request:

  • Just a small fix of the appinfo.xml to make it run on NC30. I personally tested the IMAP authentication and did a quick check for changes in authentication API's or something in NC30 but could find none.

Make the app compatible with Nextcloud 30

Signed-off-by: Ralf <ervee@moskovic.org>
@ervee
Copy link
Author

ervee commented Oct 30, 2024

Hi @violoncelloCH , could you please just merge this and do a quick release for the App Store?

My 2ct about not being able to test properly: People depending on this plugin should really have a test install they can update to NC30 and check if it still works for them. Perhaps mention that in the release note.

@ervee
Copy link
Author

ervee commented Oct 30, 2024

Or @nickvergessen @ChristophWurst could perhaps?

@nickvergessen
Copy link
Member

I'm not affiliated with the app.

@ervee
Copy link
Author

ervee commented Oct 30, 2024

I'm sorry about mentioning you then, I thought you were.

@prismopensource
Copy link

Maybe @violoncelloCH could add some extra reviewers with write access?

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nextcloud 30 support
4 participants