fix: Log attribute updates #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
|
It is quite talkative on the standard case (no updates). Intentional? |
|
It was intentional to be able to see the time between the skipped update and any slow update. But you can probably tell regardless. |
blizzz
approved these changes
Oct 8, 2024
blizzz
force-pushed
the
fix/log-attribute-update
branch
from
12cbddd
to
7490af1
Compare
- the previously used methods are deprecated as of NC 23 - … and so we do not need to check the $user object anymore either Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/log-attribute-update
branch
from
7490af1
to
f0f870d
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help localize slowness of the attribute update process.