Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(Groups): drop groups with mixed users from transition list #888

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Sep 18, 2024

this avoids testing one group all over again and again, which might be costly when large groups have to be tested (user facing request!).

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐘

lib/GroupManager.php Outdated Show resolved Hide resolved
this avoids testing one group all over again and again, which might be
costly when large groups have to be tested (user facing request!).

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com>
@blizzz blizzz force-pushed the fix/noid/drop-mixed-group-from-transition-list branch from c9f58dc to dc10c9c Compare September 18, 2024 15:44
@blizzz blizzz merged commit 8df561e into master Oct 2, 2024
47 checks passed
@blizzz blizzz deleted the fix/noid/drop-mixed-group-from-transition-list branch October 2, 2024 11:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants