Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

some tests have been disabled (temporary) whilst we implement new MPI features #454

Open
TomMelt opened this issue Dec 4, 2023 · 0 comments
Open

some tests have been disabled (temporary) whilst we implement new MPI features #454

TomMelt opened this issue Dec 4, 2023 · 0 comments
Assignees
@TomMelt
Labels
ICCS Tasks or reviews for the ICCS team
Milestone
2 Integration tests

Comments

@TomMelt
Copy link
Contributor

TomMelt commented Dec 4, 2023 •
edited
Loading

2 tests have been temporarily disabled (as part of #432):

  • testParaGrid
  • testConfigOutput

I have edited the CMakeLists.txt file to print a warning to users at build time.

CMake Warning at core/test/CMakeLists.txt:57 (message):
  testParaGrid has been temporarily disabled when running with MPI enabled

CMake Warning at core/test/CMakeLists.txt:79 (message):
  testConfigOutput has been temporarily disabled when running with MPI enabled

They have been disabled because currently ParaGrid has not implemented MPI. Therefore, building against MPI-enabled nextsimlib will cause the tests to fail.

Once @MarionBWeinzierl has finished adding MPI to Paragrid we can re-enable them.
@TomMelt TomMelt added the ICCS Tasks or reviews for the ICCS team label Dec 4, 2023
@TomMelt TomMelt added this to the 2 Integration tests milestone Dec 4, 2023
@TomMelt TomMelt self-assigned this Dec 4, 2023
TomMelt added a commit that referenced this issue Dec 4, 2023
@TomMelt
disable non-MPI tests when building with MPI
3c0d866 
disabled the following tests when MPI is enabled:
* testRectGrid
* testParaGrid
* testConfigOutput

The latter two have only been disabled temporarily.

I have raised issue #454 explaining why the tests are disabled.

They will be re-enabled after paragrid is parallelized with MPI.

`testRectGrid` has a serial version and an MPI version
(`testRectGrid_MPI`). We run the MPI version when MPI is enabled and the
serial otherwise.
@einola einola moved this to Todo in neXtSIM_DG overview Jan 8, 2024
@TomMelt TomMelt mentioned this issue Jun 11, 2024
Merged
9 tasks
TomMelt added a commit that referenced this issue Aug 21, 2024
@TomMelt
Add MPI support to ParaGrid (#560)
09dd2b2 
# Add MPI support to ParaGrid
closes #534
closes #454
closes #448 

---
# Task List
- [x] modify `make_init_para24x30.py` to use new DG data layout and
remove CG vars
- [x] add MPI doctest support to `ParaGrid_test.cpp`
- [x] move `extent` and `start` variables into `ModelArray`'s
`DimensionSpec`
- [x] add special MPI test case to `ParaGrid_test.cpp`
- [x] add MPI support to `getModelState`
- [x] add MPI support to `dumpModelState`
- [x] add MPI support to `writeDiagnosticTime`
- [x] reinstate test `ConfigOutput_test.cpp` for MPI builds
- [x] add MPI support to `ERA5`/`TOPAZ` tests

---
# Change Description

After #331 added MPI parallelisation for thermodynamics on the RectGrid,
this PR does the same for the Parametric grid. This should then check
off the second task in #120 (_"MPI parallelization of thermodynamics
where all operations, except for I/O, are local to an MPI rank"_)

---
# Test Description

- `ParaGrid_test.cpp` tests core functionality of ParaGrid (serial and
MPI)
- `./nextsim --config-file config_para24x30.cfg` should provide an
integration test (serial and MPI) (based on #506)

---
# Further work (for a future PR)

- add MPI to dynamics (to close PR #120)
- implement halo comms
- implement boundary conditions (as part of MPI) 
- tidy naming of variables in Domain Decomp tool
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@TomMelt TomMelt

Labels
ICCS Tasks or reviews for the ICCS team
Projects
neXtSIM_DG overview
Status: Todo
Milestone
2 Integration tests
Development

No branches or pull requests
1 participant
@TomMelt