Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Simplify data management in thermodynamics #725

Open
einola opened this issue Oct 28, 2024 · 0 comments
Open

Simplify data management in thermodynamics #725

einola opened this issue Oct 28, 2024 · 0 comments
Assignees
@einola
Labels
enhancement New feature or request

Comments

@einola
Copy link
Member

einola commented Oct 28, 2024

PrognosticData holds the main prognostic variables as initial, write-only values, while other model subroutines (e.g., IceGrowth and Dynamics) hold a copy of them as intermediary, read-write values.

There is no need to carry two data versions, which may give rise to unexpected errors.
@einola einola added the enhancement New feature or request label Oct 28, 2024
@einola einola self-assigned this Oct 28, 2024
einola added a commit that referenced this issue Oct 29, 2024
@einola
Ensure initialisation of temporary damage variable
cb05f46 
The temporary damage variable damageUpd was not correctly initialised in
PrognosticData::update. This commit just sets it to the value of
m_damage (as it should be done), but a proper fix would address issue
#725
@einola einola mentioned this issue Oct 29, 2024
Closed
12 tasks
@einola einola mentioned this issue Nov 21, 2024
Merged
12 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@einola einola

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@einola