Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Tests don't run on PRs that don't merge into main or develop #764

Open
jwallwork23 opened this issue Jan 2, 2025 · 1 comment · May be fixed by #765
Open

Tests don't run on PRs that don't merge into main or develop #764

jwallwork23 opened this issue Jan 2, 2025 · 1 comment · May be fixed by #765
Assignees
@TomMelt
Labels
ICCS Tasks or reviews for the ICCS team question Further information is requested

Comments

@jwallwork23
Copy link
Contributor

I have a PR (#763) that makes edits to a branch other than main or develop. To run the tests, I needed to modify the GitHub Actions workflow. Is this intended?
@jwallwork23 jwallwork23 added the question Further information is requested label Jan 2, 2025
@jwallwork23 jwallwork23 self-assigned this Jan 2, 2025
@jwallwork23 jwallwork23 moved this from Todo to In Progress in neXtSIM_DG overview Jan 2, 2025
@jwallwork23 jwallwork23 linked a pull request Jan 2, 2025 that will close this issue
Open
@jwallwork23 jwallwork23 moved this from In Progress to Review required in neXtSIM_DG overview Jan 2, 2025
@jwallwork23 jwallwork23 added the ICCS Tasks or reviews for the ICCS team label Jan 2, 2025
@jwallwork23 jwallwork23 assigned TomMelt and unassigned jwallwork23 Jan 6, 2025
@jwallwork23
Copy link
Contributor Author

Transferred ownership to @TomMelt as he said he'd be able to pick this up. See linked PR for today's brief discussion on this.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@TomMelt TomMelt

Labels
ICCS Tasks or reviews for the ICCS team question Further information is requested
Projects
neXtSIM_DG overview
Status: Review required
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable tests for PRs that don't merge into main or develop nextsimhub/nextsimdg
2 participants
@jwallwork23 @TomMelt