-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Enable tests for PRs that don't merge into main or develop #765
base: develop
Are you sure you want to change the base?
Conversation
@@ -4,7 +4,6 @@ on: | |||
push: | |||
branches: [ main, develop ] | |||
pull_request: | |||
branches: [ main, develop ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomMelt to look into draft PRs. If not, add a comment here for how to ignore certain branches.
6a91857
to
af56639
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomMelt, thank you. This looks good to me at least from what I picked up from yesterday's meeting.
ac9d672
to
f8b5d84
Compare
See comments in `.github/workflows/test_suite.yml` for more info.
f8b5d84
to
42cac55
Compare
@timspainNERSC , I just raised #769 because I realised I could merge without the tests running at all. We should be able to fix this next meeting. |
Closes #764
Closes #769
I recommend we use this approach described here i.e.,:
I think we should avoid editing
.github/workflows/test_suite.yml
.There is another popular approach using something like
if: github.event.pull_request.draft == false
in the workflow, but this comes with many problems. See here for more info.