mwe of halo exchange #744
mwe of halo exchange #744
Conversation
|
Note that I changed the logic for determining whether the Docker workflow is run. I an attempt to fix the test failure https://github.com/nextsimhub/nextsimdg/actions/runs/12009927720/job/33475689562 might it be feasible to rebase on top of or merge in Compare https://github.com/nextsimhub/nextsimdg/blob/halo-exchange/.github/workflows/docker.yml vs https://github.com/nextsimhub/nextsimdg/blob/develop/.github/workflows/docker.yml. |
TomMelt
force-pushed
the
halo-exchange
branch
from
b3882c1 to
7c3adbb
Compare
TomMelt
force-pushed
the
melt-mpi-metadata
branch
from
88f9e68 to
63e6f77
Compare
TomMelt
force-pushed
the
halo-exchange
branch
from
3adf0d1 to
e5c31a6
Compare
TomMelt
force-pushed
the
halo-exchange
branch
from
e5c31a6 to
d1b8951
Compare
TomMelt
force-pushed
the
melt-mpi-metadata
branch
from
63e6f77 to
aa15779
Compare
TomMelt
force-pushed
the
halo-exchange
branch
from
d1b8951 to
980be5e
Compare
This test includes two examples for different grid layouts: - 3 x 1 grid (3 procs) - 2 x 2 grid (4 procs) Makes use of the Slice functionality
TomMelt
force-pushed
the
halo-exchange
branch
from
980be5e to
a989bb6
Compare
| template <typename T> T& copyToBuffer(T& buffer, size_t startIndex = 0) | ||
| { | ||
| // make no especial attempt at efficiency here | ||
| SliceIter thisIter(slice, data.dimensions()); | ||
| auto biter = buffer.begin(); | ||
| auto biter = std::next(buffer.begin(), startIndex); |
There was a problem hiding this comment.
@timspainNERSC this was a bit hacky from me. I want to populate the buffer but from a specific starting index. Let me know if there's a better way of doing this.
I was trying to avoid creating temporary arrays for each of the edges.
| @@ -142,7 +142,18 @@ class Slice { | |||
| } | |||
| std::ostream& print(std::ostream& os) const | |||
| { | |||
| return os << start << ":" << stop << ":" << step; | |||
| // TODO remove me before merging into develop | |||
There was a problem hiding this comment.
TODO: remove this before merging this PR. I was using this for debugging purposes
| using SliceIter = ArraySlicer::SliceIter; | ||
|
|
||
| static const int DG = 3; | ||
| static const bool debug = true; |
There was a problem hiding this comment.
TODO: change this to false before merging
Small MWE of halo exchange logic for testing before add the main functionality to nextsim