Set up ParaGridIO_Xios as a copy of ParaGridIO for now
#758
Conversation
core/src/CMakeLists.txt
Outdated
| if(ENABLE_XIOS) | ||
| set(ParaGridIO_Impl "ParaGridIO_Xios") | ||
| else() | ||
| set(ParaGridIO_Impl "ParaGridIO") | ||
| endif() | ||
|
|
There was a problem hiding this comment.
Posibbly add the .cpp suffix here to make it clear this is a source file.
There was a problem hiding this comment.
Addressed in 1291ae4.
core/src/include/ParaGridIO_Xios.hpp
Outdated
There was a problem hiding this comment.
What are the expected differences between the current and _Xios versions of the header? Keeping the same header name would mean a lot of the changes in this PR would be unnecessary. If the header does need to change, one option would be to create both ParaGridIO_NoXios.hpp and ParaGridIO_Xios.hpp with the actual header info in, and to have #ifdef #include statements include the correct file.
There was a problem hiding this comment.
Great point! There will be parts of it that are needed by one implementation and not the other, but we can start out with selective #ifdefs and consider splitting if they diverge too far.
Addressed in 1291ae4.
Set up
ParaGridIO_Xiosas a copy ofParaGridIOfor nowCloses #552
Refinement of #751
Task List
Change Description
This PR creates a
ParaGridIO_Xiosclass for us to work on, but just copies what's inParaGridIOfor now. This means that we can convert the functionality to use XIOS piece by piece, rather than doing it all at once.I can't tick the box for "no new warnings are generated" because warnings are indeed generated to say that we're using the XIOS implementation but that it hasn't been completed yet.
Test Description
CMake for the tests needed to be reordered so that XIOS includes can be picked up.
undef INFOis added inParaGrid_testto avoid a redefinition warning.An extra CI test workflow is added that builds and runs without XIOS, so we can check that both I/O implementations are working.
Pre-Request Checklist