CLI improvements #1611
Open
CLI improvements #1611
+41
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
auspice-victorlin-build-dsi554
7 tasks
| @@ -24,6 +24,7 @@ const addParser = (parser) => { | |||
| subparser.addArgument('--handlers', {action: "store", metavar: "JS", help: "Overwrite the provided server handlers for client requests. See documentation for more details."}); | |||
| subparser.addArgument('--datasetDir', {metavar: "PATH", help: "Directory where datasets (JSONs) are sourced. This is ignored if you define custom handlers."}); | |||
| subparser.addArgument('--narrativeDir', {metavar: "PATH", help: "Directory where narratives (Markdown files) are sourced. This is ignored if you define custom handlers."}); | |||
| subparser.addArgument('--customBuildOnly', {action: "storeTrue", help: "Error if a custom build is not found."}); | |||
There was a problem hiding this comment.
I like the intention here but the word "custom" is a bit overloaded here -- this is checking if an auspice build is present in the current working directory, not whether the build has been customised (which would require introspection of the bundle).
There was a problem hiding this comment.
I've split the addition of this argument into its own commit: 0090265
Ok I understand the difference now. I chose --customBuildOnly following the previous existence of --customBuild, which seemed to be doing something similar? I can't think of a better name without being verbose like --onlyUseLocalAuspiceBuild. Do you have suggestions?
victorlin
force-pushed
the
victorlin/build-cli-improvements
branch
from
b26aeeb
to
0090265
Compare
This logic is specific to build, so keep it there.
Updated the verbose logging to be technically correct: - The index file is copied from the root to dist/, then served from there. - Only favicon.png is served from the root given the subsequent lines of routing.
This has no effect other than a printed warning, and has been like this since 55c69bb.
When running from Auspice's root directory, this replaces an unhandled scandir error with a more meaningful message.
When specified, this prevents falling back to running from build files in Auspice's root directory, which can be unintentional when running from an external project.
victorlin
force-pushed
the
victorlin/build-cli-improvements
branch
from
0090265
to
f51dff6
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See commit messages.
Related issue(s)
Testing
(to be done by a Nextstrain team member) Create preview PRs on downstream repositories.N/A