Add Nexus-Operation-Id header #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Nov 15, 2024
| * Header for the unique ID returned by the StartOperation response for async operations. Must be | ||
| * set on callback headers to support completing operations before the start response is received. | ||
| */ | ||
| public static final String HEADER_OPERATION_ID = "Nexus-Operation-Id"; |
There was a problem hiding this comment.
Suggested change
| public static final String HEADER_OPERATION_ID = "Nexus-Operation-Id"; | |
| public static final String OPERATION_ID = "Nexus-Operation-Id"; |
Figured we don't need to prefix since we didn't for the other two and they are in this class (but can add NEXUS_ if you want, but I don't think it's needed)
There was a problem hiding this comment.
Removed HEADER_
Quinn-With-Two-Ns
force-pushed
the
Nexus-Operation-Id
branch
from
3d651a2 to
4e23fe6
Compare
cretz
approved these changes
Nov 18, 2024
bergundy
approved these changes
Nov 20, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Nexus-Operation-Id header
see also: nexus-rpc/api#12