Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix phantompeakqualtools protection stack overflow #269

Merged
merged 4 commits into from
Apr 1, 2022
Merged

Fix phantompeakqualtools protection stack overflow #269

merged 4 commits into from
Apr 1, 2022

Conversation

JoseEspinosa
Copy link
Member

Fix phantompeakqualtools protection stack overflow reported in #220

  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • CHANGELOG.md is updated

@JoseEspinosa JoseEspinosa changed the base branch from master to dev March 31, 2022 13:10
@JoseEspinosa JoseEspinosa marked this pull request as ready for review April 1, 2022 08:32
drpatelh
drpatelh approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@drpatelh drpatelh merged commit 813cb38 into nf-core:dev Apr 1, 2022
@JoseEspinosa JoseEspinosa mentioned this pull request Apr 1, 2022
Closed
@JoseEspinosa JoseEspinosa deleted the i_220 branch April 20, 2022 09:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoseEspinosa @drpatelh