Skip to content

Commit

Permalink
Merge pull request #298 from drpatelh/fixes
Browse files Browse the repository at this point in the history
export CONDA_PREFIX into container when using Singularity and Apptainer
  • Loading branch information
drpatelh committed Feb 29, 2024
2 parents 03ac573 + cdc31b9 commit 755ca35
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Special thanks to the following for their contributions to the release:
- [Alexandru Mizeranschi](https://github.com/nicolae06)
- [Alexander Blaessle](https://github.com/alexblaessle)
- [Lukas Forer](https://github.com/lukfor)
- [Matt Niederhuber](https://github.com/mniederhuber)
- [Maxime Garcia](https://github.com/maxulysse)
- [Sateesh Peri](https://github.com/sateeshperi)
- [Sebastian Uhrig](https://github.com/suhrig)
Expand Down Expand Up @@ -54,6 +55,7 @@ Thank you to everyone else that has contributed by reporting bugs, enhancements
- [PR #294](https://github.com/nf-core/fetchngs/pull/294) - Replace mermaid diagram with subway map
- [PR #295](https://github.com/nf-core/fetchngs/pull/295) - Be less stringent with test expectations for CI
- [PR #296](https://github.com/nf-core/fetchngs/pull/296) - Remove params.outdir from tests where required and update snapshots
- [PR #298](https://github.com/nf-core/fetchngs/pull/298) - `export CONDA_PREFIX` into container when using Singularity and Apptainer

### Software dependencies

Expand Down
5 changes: 5 additions & 0 deletions modules/local/aspera_cli/main.nf
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,11 @@ process ASPERA_CLI {

script:
def args = task.ext.args ?: ''
def conda_prefix = ['singularity', 'apptainer'].contains(workflow.containerEngine) ? "export CONDA_PREFIX=/usr/local" : ""
if (meta.single_end) {
"""
$conda_prefix
ascp \\
$args \\
-i \$CONDA_PREFIX/etc/aspera/aspera_bypass_dsa.pem \\
Expand All @@ -36,6 +39,8 @@ process ASPERA_CLI {
"""
} else {
"""
$conda_prefix
ascp \\
$args \\
-i \$CONDA_PREFIX/etc/aspera/aspera_bypass_dsa.pem \\
Expand Down
8 changes: 0 additions & 8 deletions nextflow.config
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,6 @@ try {
// Workflow specific configs
includeConfig './workflows/sra/nextflow.config'

// Load nf-core/fetchngs custom profiles from different institutions.
// Warning: Uncomment only if a pipeline-specific institutional config already exists on nf-core/configs!
// try {
// includeConfig "${params.custom_config_base}/pipeline/fetchngs.config"
// } catch (Exception e) {
// System.err.println("WARNING: Could not load nf-core/config/fetchngs profiles: ${params.custom_config_base}/pipeline/fetchngs.config")
// }

profiles {
debug {
dumpHashes = true
Expand Down

0 comments on commit 755ca35

Please # to comment.