Include statement for installed module ends on wrong `

[FriederikeHanssen]

Description of the bug

The include statement ends on the wrong quote type , should be ' instead

Command used and terminal output

nf-core modules install mosdepth

 Include statement: include { MOSDEPTH } from '../modules/nf-core/modules/mosdepth/main’

System information

tools version 2.4.1
macos

[PritamSarbajna]

can someone assign me this issue ?

[ewels]

can someone assign me this issue ?

Done! You're welcome to assign yourself to issues if you're intending to work on them :)

[PritamSarbajna]

mosdepth

can you please give me a little hint that where to find it ?
@FriederikeHanssen

[PritamSarbajna]

hey @ewels
I think this issue is actually on nf-core/modules

[ewels]

No, it's here:

tools/nf_core/modules/install.py

Line 135 in f8de281

log.info(f"Include statement: include {{ {module_name} }} from '.{os.path.join(*install_folder, module)}/main’")

The final character ’ should be a '

[PritamSarbajna]

thank you @ewels really appreciate it as a beginner to opensource. Just want to know after fixing it should I have to update the CHANGELOG.md also ?

[ewels]

Normally yes, but as this is such a small edit I don't think that there's any need 👍🏻 Please do a fork and then make a pull-request though.

If you like you could also make the statement coloured:

 log.info(f"Include statement: [magenta]include {{ {module_name} }} from '.{os.path.join(*install_folder, module)}/main'")

The logging uses the python Rich library, which is where the [magenta] thing is used: https://rich.readthedocs.io/en/stable/markup.html