-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fixed a code bug #1649
Fixed a code bug #1649
Conversation
This PR is against the
|
Codecov Report
@@ Coverage Diff @@
## dev #1649 +/- ##
==========================================
- Coverage 64.84% 64.81% -0.04%
==========================================
Files 54 54
Lines 6270 6270
==========================================
- Hits 4066 4064 -2
- Misses 2204 2206 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice catch! For next time though, please provide a short description of what you've changed. It makes it easier to review your code.
hey @ErikDanielsson so sorry I had actually written whole description of what I had done in the comment |
Ah, I see! Yeah, that's an easy mistake to make |
I have fixed a code bug
it was before - log.info(f"Include statement: include {{ {module_name} }} from '.{os.path.join(*install_folder, module)}/main’")
it is now - log.info(f"Include statement: include {{ {module_name} }} from '.{os.path.join(*install_folder, module)}/main'")
it is a difference between this ’ and this '
it is actually the issue referenced #1640
PR checklist
CHANGELOG.md
is updateddocs
is updated