-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Template: Fix GitHub Actions CI and Linting badges links #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev -> master for 2.12
Dev -> Master for 2.12.1
Fixed GitHub Actions CI and Linting badges links.
maxulysse
changed the title
Raq manzano patch 1
Fix GitHub Actions CI and Linting badges links
Feb 15, 2024
ewels
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! One minor change - to update the link to the CI runs as well as just the badge.
Also you put the linting comment workflow rather than the linting :) The linting comment CI is the job that posts a comment after linting fails, which is kind of irrelevant. It always passes even if linting is failing.
ewels
changed the title
Fix GitHub Actions CI and Linting badges links
Template: Fix GitHub Actions CI and Linting badges links
Feb 15, 2024
This comment was marked as resolved.
This comment was marked as resolved.
mashehu
approved these changes
Feb 15, 2024
maxulysse
approved these changes
Feb 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed GitHub Actions CI and Linting badges links.