Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Linting: Handle multiple aliases in module imports correctly during linting #2762

Merged
merged 5 commits into from
Feb 19, 2024
Merged

Linting: Handle multiple aliases in module imports correctly during linting #2762

merged 5 commits into from
Feb 19, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Feb 16, 2024

closes #2726

@codecov Codecov
Copy link

codecov bot commented Feb 16, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (364a836) 73.33% compared to head (03a0226) 73.45%.

Files Patch % Lines
nf_core/subworkflows/lint/main_nf.py 92.30% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mirpedrol
mirpedrol approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mashehu mashehu merged commit 0193225 into nf-core:dev Feb 19, 2024
35 checks passed
@mirpedrol mirpedrol mentioned this pull request Feb 19, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mashehu @mirpedrol @nf-core-bot