Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove if/else block to include igenomes.config and add igenomes_ignored.config #3168

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Remove if/else block to include igenomes.config and add igenomes_ignored.config #3168

merged 5 commits into from
Sep 27, 2024

Conversation

mirpedrol
Copy link
Member

Close #3131

ewels
ewels approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Maybe worth adding lint test to check that conf/igenomes_ignored.config exists? I guess something similar is in place for conf/igenomes.config? If not then don't worry about it.

@ewels ewels added this to the 3.0 milestone Sep 26, 2024
@mirpedrol mirpedrol merged commit 9f4a4bb into nf-core:dev Sep 27, 2024
83 checks passed
@mirpedrol mirpedrol deleted the genomes-map branch September 27, 2024 15:00
@mirpedrol mirpedrol mentioned this pull request Sep 30, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mirpedrol @ewels @maxulysse