Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TEMPLATE: Fix version comment action #3212

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Oct 9, 2024

No description provided.

@mashehu mashehu requested a review from mirpedrol October 9, 2024 13:54
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came across this issue in 3.0.1 😬

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still not working 😭
cf nf-core/sarek#1681

@mirpedrol
Copy link
Member

Looks like there is an error with the action to read the yaml file pietrobolcato/action-read-yaml#14 should we try the fork mentioned in this issue?

@maxulysse
Copy link
Member

As far as I can tell all PRs once a template sync has been merged ran into this error

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working now 🙂 LGTM!

@mashehu mashehu requested a review from maxulysse October 10, 2024 13:42
@maxulysse
Copy link
Member

CHANGELOG?

@mirpedrol mirpedrol force-pushed the fix-template-version-comment-action branch from 1b9d8e9 to 1b429cb Compare October 11, 2024 07:08
@mirpedrol mirpedrol merged commit 5d368d7 into nf-core:dev Oct 11, 2024
83 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants