Skip to content

Add docker support in pipeline download #3516

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 10 commits into from

Conversation

nikhil
Copy link

@nikhil nikhil commented Mar 26, 2025

Resolves: #2309

This PR adds docker support to the pipeline download functionality

This PR uses the guide to download the image: nextflow-io/nextflow#4708

It mimics Singularity's cache env variable by using the new env variable NXF_DOCKER_CACHEDIR, the downside is that this is not an official env in nextflow and the user needs to run

ls -1 [$NXF_DOCKER_CACHEDIR]/*.tar | xargs --no-run-if-empty -L 1 docker load -i

on their own as nextflow currently has no way of loading offline tar files

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@nikhil nikhil requested review from mashehu and mirpedrol March 26, 2025 17:30
@MatthiasZepper
Copy link
Member

MatthiasZepper commented Mar 26, 2025

Looks like this will run into merge conflicts as there are multiple refactors running concurrently (
#3509, #3506)

😱 Yes, that is likely inevitable! Unfortunately, I did not know that you were working on this task at all! We coordinated the other refactors via Zoom and Slack and I have asked multiple times in the channel that people working on tasks should come forward. I was online on Monday and Tuesday until 1.a.m. UTC so people from the Americas could reach out if help was needed.

😰 This is now very unfortunate, but it seemed to be the easiest for testing and maintenance to move all Singularity download functions into a separate class and build an analogous Docker download class later. Do you think that you could move your work into a similar class like in #3509? Basically, one that just takes the container strings and registries and then downloads the container images?

@nikhil nikhil mentioned this pull request Mar 26, 2025
4 tasks
@nikhil
Copy link
Author

nikhil commented Mar 26, 2025

No worries! I must have missed that on the hackathon slack channel, I added a draft PR of my work into a docker class using the singularity class as a base. Its located here: #3517. Should be good to add once the other PR is in

@nikhil
Copy link
Author

nikhil commented Mar 26, 2025

I am going to close this PR since this should not get merged

@nikhil nikhil closed this Mar 26, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants