Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Assay.yaml #376

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Update Assay.yaml #376

merged 2 commits into from
Dec 5, 2023

Conversation

cconrad8
Copy link
Contributor

@cconrad8 cconrad8 commented Dec 5, 2023

No description provided.

@cconrad8 cconrad8 requested a review from anngvu December 5, 2023 00:50
@cconrad8
Copy link
Contributor Author

cconrad8 commented Dec 5, 2023

https://sagebionetworks.jira.com/jira/servicedesk/projects/NFOSI/queues/custom/7/NFOSI-760

Contributor asked to add nanoparticle tracking analysis to metadata dictionary

Copy link

github-actions bot commented Dec 5, 2023

Test Suite Report

Template Generation

template result link
ClinicalAssayTemplate 😄 template link
EpigeneticsAssayTemplate 😄 template link
FlowCytometryTemplate 😄 template link
GenomicsAssayTemplate 😄 template link
GenomicsAssayTemplateExtended 😄 template link
ImagingAssayTemplate 😄 template link
LightScatteringAssayTemplate 😄 template link
MRIAssayTemplate 😄 template link
PharmacokineticsAssayTemplate 😄 template link
PlateBasedReporterAssayTemplate 😄 template link
ProcessedAlignedReadsTemplate 😄 template link
ProcessedExpressionTemplate 😄 template link
ProcessedVariantCallsTemplate 😄 template link
ProteomicsAssayTemplate 😄 template link
ProtocolTemplate 😄 template link
RNASeqTemplate 😄 template link
ScRNASeqTemplate 😄 template link
UpdateMilestoneReport 😄 template link
WESTemplate 😄 template link
WGSTemplate 😄 template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv 😄 Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv 😄 Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv 😄 Conditional validation for attributes is currently not supported
ScRNASeqTemplate_0.csv 😄 Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv 😄 Fail because of missing data in required field libraryStrand

@anngvu anngvu merged commit a28acb5 into main Dec 5, 2023
@anngvu anngvu deleted the cconrad8-patch-nanoparticletracking branch December 5, 2023 18:50
Copy link
Collaborator

@anngvu anngvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants