Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Patch/schematic update #396

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Patch/schematic update #396

merged 3 commits into from
Feb 16, 2024

Conversation

anngvu
Copy link
Collaborator

@anngvu anngvu commented Feb 14, 2024

  • Update schematic CI to use 24.1.1 for generating templates, validating templates in test suite
    • Note: for some reason, absolutely cannot use Python 3.10.04 (default version on ubuntu-22.04) with schematic 24.1.1, this was a weird error to hunt down
  • Add new institutions to test changes + accommodate DSP submissions

Reviewers added for awareness/to confirm that things are updated and functionality remains fine

Copy link

github-actions bot commented Feb 14, 2024

Test Suite Report

Template Generation

template result link
ClinicalAssayTemplate 😄 template link
EpigeneticsAssayTemplate 😄 template link
FlowCytometryTemplate 😄 template link
GenomicsAssayTemplate 😄 template link
GenomicsAssayTemplateExtended 😄 template link
ImagingAssayTemplate 😄 template link
LightScatteringAssayTemplate 😄 template link
MRIAssayTemplate 😄 template link
PharmacokineticsAssayTemplate 😄 template link
PlateBasedReporterAssayTemplate 😄 template link
ProcessedAlignedReadsTemplate 😄 template link
ProcessedExpressionTemplate 😄 template link
ProcessedVariantCallsTemplate 😄 template link
ProteomicsAssayTemplate 😄 template link
ProtocolTemplate 😄 template link
RNASeqTemplate 😄 template link
ScRNASeqTemplate 😄 template link
UpdateMilestoneReport 😄 template link
WESTemplate 😄 template link
WGSTemplate 😄 template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv 😄 Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv 😄 Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv 😄 Conditional validation for attributes is currently not supported
ScRNASeqTemplate_0.csv 😄 Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv 😄 Fail because of missing data in required field libraryStrand

@anngvu anngvu force-pushed the patch/schematic-update branch 3 times, most recently from fe26974 to edf604f Compare February 15, 2024 00:30
@anngvu anngvu requested review from allaway and cconrad8 February 15, 2024 00:47
@anngvu anngvu force-pushed the patch/schematic-update branch from 8ade4a5 to c5aa0f7 Compare February 15, 2024 20:48
@anngvu anngvu merged commit 494fe54 into main Feb 16, 2024
@anngvu anngvu deleted the patch/schematic-update branch February 16, 2024 15:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants