Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Patch cc #540

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Patch cc #540

merged 3 commits into from
Nov 4, 2024

Conversation

cconrad8
Copy link
Contributor

@cconrad8 cconrad8 commented Nov 4, 2024

No description provided.

@cconrad8 cconrad8 linked an issue Nov 4, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Nov 4, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-04 21:40 UTC

@cconrad8 cconrad8 requested a review from anngvu November 4, 2024 17:21
Copy link

github-actions bot commented Nov 4, 2024

Test Suite Report 24.7.2

Template Generation

template result link
ClinicalAssayTemplate 😄 template link
EpigeneticsAssayTemplate 😄 template link
FlowCytometryTemplate 😄 template link
GenomicsAssayTemplate 😄 template link
GenomicsAssayTemplateExtended 😄 template link
HumanCohortTemplate 😄 template link
ImagingAssayTemplate 😄 template link
LightScatteringAssayTemplate 😄 template link
MethylationArrayTemplate 😄 template link
MRIAssayTemplate 😄 template link
PharmacokineticsAssayTemplate 😄 template link
PlateBasedReporterAssayTemplate 😄 template link
ProcessedAlignedReadsTemplate 😄 template link
ProcessedExpressionTemplate 😄 template link
ProcessedVariantCallsTemplate 😄 template link
ProteomicsAssayTemplate 😄 template link
ProtocolTemplate 😄 template link
RNASeqTemplate 😄 template link
ScRNASeqTemplate 😄 template link
UpdateMilestoneReport 😄 template link
WESTemplate 😄 template link
WGSTemplate 😄 template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv 😄 Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv 😄 Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv 😄 Conditional validation for attributes is currently not supported
GenomicsAssayTemplate_control.csv 😄 There should be no issue with this template.
ScRNASeqTemplate_0.csv 😄 Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv 😄 Fail because of missing data in required field libraryStrand

Manifest Submission

manifest pass
GenomicsAssayTemplate_0.csv 😄
GenomicsAssayTemplate_1.csv 😄
GenomicsAssayTemplate_2.csv 😄
GenomicsAssayTemplate_control.csv 😄
ScRNASeqTemplate_0.csv

@anngvu anngvu merged commit 717304f into main Nov 4, 2024
@anngvu anngvu deleted the patch-cc branch November 4, 2024 21:39
@anngvu
Copy link
Collaborator

anngvu commented Nov 4, 2024

@cconrad8 Could you make another PR for meningiomaCharacterization ?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ID collision for two entities MPNST and menigioma
3 participants