-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Updates for issues #81 #82 #83 #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested some changes for consistency and formatting of brand names.
One other general comment is whether we should remove "assay" from the "assay" values eg 2D CellTiter-Glo assay
since it's a little redundant, but I don't know if that matters all that much.
I just realized that my changes in the csv wouldn't be reflected in the json-ld, so I dismissed my approval :) Let me know if these changes look good to you and then if you can regenerate the json-ld, I'll approve the changes. thanks! |
Co-authored-by: Robert Allaway <allaway@users.noreply.github.com>
Co-authored-by: Robert Allaway <allaway@users.noreply.github.com>
Co-authored-by: Robert Allaway <allaway@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks for the review! Definitely helps these terms to be cleaner. Applied all review formatting suggestions and added 2 commits, the first in consideration of
and the second to take care of
|
Add more granular viability assay terms
Add new library kit value
Add new value for readStrandOrientation