Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates for issues #81 #82 #83 #83

Merged
merged 8 commits into from
Nov 3, 2021
Merged

Updates for issues #81 #82 #83 #83

merged 8 commits into from
Nov 3, 2021

Conversation

anngvu
Copy link
Collaborator

@anngvu anngvu commented Nov 2, 2021

Add more granular viability assay terms
Add new library kit value
Add new value for readStrandOrientation

allaway
allaway previously approved these changes Nov 2, 2021
Copy link
Contributor

@allaway allaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some changes for consistency and formatting of brand names.

One other general comment is whether we should remove "assay" from the "assay" values eg 2D CellTiter-Glo assay since it's a little redundant, but I don't know if that matters all that much.

@allaway allaway dismissed their stale review November 2, 2021 23:58

jsonld not up to date

@allaway
Copy link
Contributor

allaway commented Nov 2, 2021

I just realized that my changes in the csv wouldn't be reflected in the json-ld, so I dismissed my approval :)

Let me know if these changes look good to you and then if you can regenerate the json-ld, I'll approve the changes. thanks!

anngvu and others added 6 commits November 3, 2021 07:51
Co-authored-by: Robert Allaway <allaway@users.noreply.github.com>
Co-authored-by: Robert Allaway <allaway@users.noreply.github.com>
Co-authored-by: Robert Allaway <allaway@users.noreply.github.com>
@allaway allaway self-requested a review November 3, 2021 15:10
Copy link
Contributor

@allaway allaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@allaway allaway merged commit 570d792 into nf-osi:main Nov 3, 2021
@anngvu
Copy link
Collaborator Author

anngvu commented Nov 3, 2021

Thanks for the review! Definitely helps these terms to be cleaner. Applied all review formatting suggestions and added 2 commits, the first in consideration of

general comment is whether we should remove "assay" from the "assay" values

and the second to take care of

regenerate the json-ld

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants