Fix compatibility with minor Python updates (3.12.6 to 3.12.7, 3.11.7 to 3.11.8) #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to zipfile changes in from Python 3.11.8 to 3.11.7 openpyxl was updated to still correctly close open files.
dalito
changed the title
dalito
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code fixes:
choicesparameter in theadd_docs_subparserfunction. This is required due to changes made in argparse in Python 3.12.7.Dependency updates:
openpyxlfrom>= 3.0.9to>= 3.1.5. This is required since Python 3.11.8 broke file-closing) in openpyxl on Windows.Closes #231