Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Some penalty_teams incorrect for JAX games <= 2015 #174

Closed
mrcaseb opened this issue Feb 5, 2021 · 0 comments · Fixed by #173
Closed

Some penalty_teams incorrect for JAX games <= 2015 #174

mrcaseb opened this issue Feb 5, 2021 · 0 comments · Fixed by #173

Comments

@mrcaseb
Copy link
Member

mrcaseb commented Feb 5, 2021

see nflverse/nflverse-pbp#47
mrcaseb added a commit that referenced this issue Feb 5, 2021
@mrcaseb
Fix penaly_team for pre 2016 JAX games
e7499e1 
closes #174
@mrcaseb mrcaseb mentioned this issue Feb 5, 2021
Merged
@mrcaseb mrcaseb linked a pull request Feb 5, 2021 that will close this issue
Make penalty_fix==0 when penalty==1 and play_type_nfl=="PENALTY" #173
Merged
mrcaseb added a commit that referenced this issue Feb 5, 2021
@mrcaseb
Make penalty_fix==0 when penalty==1 and play_type_nfl=="PENALTY" (
3aacd70 
#173)

* Make `penalty_fix==0` when `penalty==1` and `play_type_nfl=="PENALTY"`

* fix typo

* Fix `penaly_team` for pre 2016 JAX games
closes #174
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make penalty_fix==0 when penalty==1 and play_type_nfl=="PENALTY" nflverse/nflfastR
1 participant
@mrcaseb