Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix bad yardlines #322

Merged
merged 1 commit into from
May 16, 2022
Merged

fix bad yardlines #322

merged 1 commit into from
May 16, 2022

Conversation

guga31bb
Copy link
Member

No description provided.

@guga31bb guga31bb linked an issue May 16, 2022 that may be closed by this pull request
@guga31bb
Copy link
Member Author

guga31bb commented May 16, 2022

Great success

> fast_scraper("2000_01_CAR_WAS") %>% filter(play_id == 1676) %>% select(yrdln, side_of_field, yardline_100)
√ 15:52:37 | Download finished. Adding variables...
√ 15:52:37 | added game variables
√ 15:52:37 | added nflscrapR variables
√ 15:52:38 | added ep variables
i 15:52:38 | No non-NA air_yards detected. air_yac_ep variables set to NA
√ 15:52:38 | added wp variables
i 15:52:38 | No non-NA air_yards detected. air_yac_wp variables set to NA
i 15:52:38 | No non-NA values for cp calculation detected. cp and cpoe set to NA
√ 15:52:38 | added fixed drive variables
√ 15:52:39 | added series variables
√ 15:52:39 | Procedure completed.
# A tibble: 1 x 3
  yrdln  side_of_field yardline_100
  <chr>  <chr>                <dbl>
1 WAS 20 WAS                     80

Old output for comparison:

  yrdln side_of_field yardline_100
  <chr> <chr>                <dbl>
1 WAS20 WAS20                   NA

@guga31bb guga31bb requested a review from mrcaseb May 16, 2022 20:01
Copy link
Member

@mrcaseb mrcaseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@mrcaseb mrcaseb enabled auto-merge May 16, 2022 20:09
@mrcaseb mrcaseb merged commit 61cde62 into master May 16, 2022
@mrcaseb mrcaseb deleted the side_of_field branch May 16, 2022 20:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad yardlines
2 participants