Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

calculate_player_stats_def now returns season_type if argument weekly is set to TRUE #455

Merged
merged 2 commits into from
Jan 15, 2024
Merged

calculate_player_stats_def now returns season_type if argument weekly is set to TRUE #455

merged 2 commits into from
Jan 15, 2024

Conversation

mrcaseb
Copy link
Member

@mrcaseb mrcaseb commented Jan 15, 2024

this is part of some adjustments for #454

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2024 •
edited
Loading

🚀 Deployed on https://65a58310cdaac220bd98f7b3--thirsty-brown-d38ddf.netlify.app

@mrcaseb mrcaseb requested a review from tanho63 January 15, 2024 18:59
@mrcaseb mrcaseb enabled auto-merge (rebase) January 15, 2024 18:59
tanho63
tanho63 reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@tanho63 tanho63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to bump version number but otherwise LGTM

tanho63
tanho63 approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@tanho63 tanho63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrcaseb mrcaseb merged commit 8df5c6b into master Jan 15, 2024
6 checks passed
@mrcaseb mrcaseb deleted the season-type-in-defstats branch January 15, 2024 19:08
@mrcaseb
Copy link
Member Author

mrcaseb commented Jan 15, 2024

Thanks for the version bump @tanho63
I knew I forgot something but ran out of time

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tanho63 tanho63 tanho63 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrcaseb @tanho63