Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add new penalty type from dynamic kickoff rules #486

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Add new penalty type from dynamic kickoff rules #486

merged 2 commits into from
Sep 17, 2024

Conversation

mrcaseb
Copy link
Member

@mrcaseb mrcaseb commented Sep 17, 2024

Here is an example of plays where nflfastR didn't parse the penalty type
image

@mrcaseb
Copy link
Member Author

mrcaseb commented Sep 17, 2024

Fix confirmed. Hopefully NFL sticks to the formulation
image

@mrcaseb mrcaseb linked an issue Sep 17, 2024 that may be closed by this pull request
[BUG] Kickoffs short of the landing zone have NA for their penalty_type #485
Closed
2 tasks
@mrcaseb mrcaseb requested a review from guga31bb September 17, 2024 13:58
@mrcaseb mrcaseb enabled auto-merge (rebase) September 17, 2024 14:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

🚀 Deployed on https://66e98de411ad09056061bc70--thirsty-brown-d38ddf.netlify.app

@mrcaseb mrcaseb disabled auto-merge September 17, 2024 14:20
@mrcaseb mrcaseb merged commit eb133e6 into master Sep 17, 2024
7 checks passed
@mrcaseb mrcaseb deleted the new-ko-penalty branch September 17, 2024 14:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@guga31bb guga31bb guga31bb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Kickoffs short of the landing zone have NA for their penalty_type
2 participants
@mrcaseb @guga31bb