Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improved parsing of URLs with symbols #432

Merged
merged 3 commits into from
Mar 25, 2023
Merged

Improved parsing of URLs with symbols #432

merged 3 commits into from
Mar 25, 2023

Conversation

nfrasser
Copy link
Owner

@nfrasser nfrasser commented Feb 26, 2023 •
edited
Loading

Fixes #427
Fixes #430

@nfrasser nfrasser self-assigned this Feb 26, 2023
@coveralls
Copy link

coveralls commented Feb 27, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4519589768

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 96.105%
Totals Coverage Status
Change from base Build 4270846189: 0.1%
Covered Lines: 1120
Relevant Lines: 1139
💛 - Coveralls

Nick Frasser added 2 commits March 25, 2023 10:01
Remove NUM from LocalPartAccepting token group
0cfea9f 
Interferes with domain tokens when parsing numbers such as www.drive1.com
Complex email HTML test
844921c
@nfrasser nfrasser merged commit afc51f1 into main Mar 25, 2023
@nfrasser nfrasser deleted the parser-fixes branch March 25, 2023 14:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@nfrasser nfrasser

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nfrasser @coveralls