feat: use application/vnd.ipld.car as preferred content-type #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
d07b52f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://96b2fc04.nft-storage-1at.pages.dev |
lidel
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
lgtm, https://www.iana.org/assignments/media-types/application/vnd.ipld.car
@yusefnapora anything blocking you from merging this?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1758 by making
application/vnd.ipld.carthe main Content-Type for CAR uploads. The API will still acceptapplication/car, but the client will sendapplication/vnd.ipld.car.Important: since this changes the client behavior, we need to deploy the API before publishing a new client version.