Skip to content

Commit

Permalink
Sharedmem skip (#1907)
Browse files Browse the repository at this point in the history
* sharedmem added to invalid_resources check

* scheduler properly stops jobs with sharedmem > 0

* removed sharedmem from MIN_RESOURCE

* reverted last commit and made a check for zero value sharemem resources

* reverted model to always strip sharemem resource

* reverted comment
  • Loading branch information
matttalda authored Aug 18, 2020
1 parent 2d5fed4 commit 5395e94
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions scale/scheduler/scheduling/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -368,10 +368,11 @@ def _process_queue(self, nodes, job_types, job_type_limits, job_type_resources,
insufficient_resources = []
# get resource names offered and compare to job type resources
for resource in job_exe.required_resources.resources:
# skip sharedmem
if resource.name.lower() == 'sharedmem':
continue
if resource.name not in max_cluster_resources._resources:
# Check for invalid resource or sharedmem
if (resource.name not in max_cluster_resources._resources) or (resource.name.lower() == 'sharedmem'):
# Skip sharedmem if its 0
if (resource.name.lower() == 'sharedmem') and (resource.value <= 0):
continue
if jt.name in type_warnings:
type_warnings[jt.name]['count'] += 1
if resource.name not in type_warnings[jt.name]['warning']:
Expand Down

0 comments on commit 5395e94

Please # to comment.