Review Data Filter Conditions #1760
Comments
gisjedi
pushed a commit
that referenced
this issue
Sep 11, 2019
* 📚 Updating data filter description to clarify filter types, conditions, etc * 🔨 Changing 'in' conditions to only check overall list and not each item in the list; changing type variables to filter_type so we don't conflict with the keyword; adding test for 'array' type * ✅ Fixing tests * 🔨 Fixing transient batch testing bug and 504 error with empty results for creating dataset members * 👌 Clarifying condition input params * 👌 Adding examples for each condition Closes #1760 Fixes #1772; Fixes #1773
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Pain Point? Please describe.
Review the data filter conditions and see if they make sense. Also update documentation to make them clearer. For example, when using contains you are checking if the value being inspected contains one of the values in the list from the condition. Currently the 'in' condition checks if the output is in the list of values or is a subset of one of the values in the list. We probably want to change this so it just checks the former.
Desired Solution
A clear and concise description of what you want to happen.
Alternative / Workaround
A clear and concise description of any alternative solutions or features you've considered.
Additional Context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: