Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Transfer_suffix is required for directory strikes #1768

Closed
Fizz11 opened this issue Sep 4, 2019 · 1 comment
Closed

Transfer_suffix is required for directory strikes #1768

Fizz11 opened this issue Sep 4, 2019 · 1 comment
Assignees
@Fizz11
Labels
bug
Milestone
Sprint 7

Comments

@Fizz11
Copy link
Contributor

Fizz11 commented Sep 4, 2019

Description
Transfer_suffix is currently optional in the UI, however the strike will fail if it is missing.

Reproduction Steps
Steps to reproduce the problem:

  1. make a directory strike

Additional context
easy fix is to set default value to _tmp if value is not provided in the UI. also update documentation to label it optional.
@Fizz11 Fizz11 added the bug label Sep 4, 2019
@Fizz11 Fizz11 self-assigned this Sep 4, 2019
Fizz11 added a commit that referenced this issue Oct 2, 2019
@Fizz11
#1768 - Transfer_suffix required for directory strikes (#1771)
2b70f8e 
* give transfer_suffix a default value and make it not required in validation

* 📚 🔨 ✅ Updating docs to specify default of _tmp, adding warning and updating tests
@emimaesmith emimaesmith added this to the Sprint 7 milestone Oct 15, 2019
@emimaesmith
Copy link
Contributor

Closed via #1771

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Fizz11 Fizz11

Labels
bug
Projects
None yet
Milestone
Sprint 7
Development

No branches or pull requests
2 participants
@emimaesmith @Fizz11