Skip to content

adds for_system_vms to cs_vlan_ip_range (#15) #18

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Aug 15, 2020

Conversation

rvalle
Copy link
Collaborator

@rvalle rvalle commented Aug 12, 2020

I have created the missing API option "for system vms" in order to address issue #15.
I have created an integration test that will set it on the simulator and check that it was set OK
I have also modify an existing test to ensure that the setting defaults to false.

I still have not integrated my devenv with a production platform, so I still have to test that this works on a real ACS deployment.

@rvalle
Copy link
Collaborator Author

rvalle commented Aug 12, 2020

@resmo I am not sure what is happening.
In my environment integration and sanity tests are now working, but I am launching them with the ansible-base pip install.

Copy link
Member

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@resmo resmo merged commit 81df358 into ngine-io:master Aug 15, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants