Skip to content

New VM Instance Inventory Plugin #66

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
Apr 9, 2021

Conversation

rvalle
Copy link
Collaborator

@rvalle rvalle commented Feb 4, 2021

This PR fixes #26

This is a clean version of PR #61

@rvalle rvalle requested a review from resmo February 4, 2021 11:54
@rvalle rvalle self-assigned this Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #66 (56099f8) into master (badff84) will decrease coverage by 0.07%.
The diff coverage is 80.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   84.36%   84.29%   -0.08%     
==========================================
  Files          53       56       +3     
  Lines        5500     5590      +90     
  Branches     1246     1256      +10     
==========================================
+ Hits         4640     4712      +72     
- Misses        429      443      +14     
- Partials      431      435       +4     
Impacted Files Coverage Δ
plugins/inventory/instance.py 79.26% <79.26%> (ø)
plugins/doc_fragments/cloudstack_environment.py 100.00% <100.00%> (ø)
plugins/module_utils/cloudstack.py 71.95% <0.00%> (-0.23%) ⬇️
plugins/modules/cs_physical_network.py 82.55% <0.00%> (ø)
plugins/doc_fragments/cloudstack.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update badff84...56099f8. Read the comment docs.

---
instance:

name: {{instance.name}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a blocker but consider spaces between brackets.

@rvalle rvalle requested a review from resmo April 9, 2021 08:23
@rvalle rvalle changed the title New Inventory Plugin New VM Instance Inventory Plugin Apr 9, 2021
@rvalle rvalle requested a review from resmo April 9, 2021 13:31
@resmo resmo merged commit df7df7e into ngine-io:master Apr 9, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new style inventory plugin
2 participants